-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major/uppsf 986 update kafka lib #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not look like it's working properly, when I send a message to be picked by the service, I see the following in the logs:
generic-rw-s3-9595c7b98-72nmk generic-rw-s3 Failed to obtain reader, logger is not initialised - please use InitLogger or InitDefaultLogger function
main.go
Outdated
@@ -119,6 +119,11 @@ func main() { | |||
EnvVar: "REQUEST_LOGGING_ENABLED", | |||
}) | |||
|
|||
logConf := log.KeyNamesConfig{KeyTime: "@time"} | |||
logger := log.NewUPPLogger(*appName, *logLevel, logConf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*appName, *logLevel receive their values from the user input in the app.Action block.
} | ||
|
||
logger.InitLogger(*appName, *logLevel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need to remove this. I think this is still used in the other parts of the service.
01199b0
to
7ff1a4f
Compare
Apply go mod tidy Start using go-logger/v2 in main.go
7ff1a4f
to
756f32a
Compare
…fka-lib Major/uppsf 986 update kafka lib
Bump service to v2
Start using go-logger/v2 in main.go
Move to v1.0.0 of
message-queue-gosumer